fix(core)!: include multimodal blocks in get_buffer_string prefix format#38174
Open
Mason Daugherty (mdrxy) wants to merge 1 commit into
Open
fix(core)!: include multimodal blocks in get_buffer_string prefix format#38174Mason Daugherty (mdrxy) wants to merge 1 commit into
get_buffer_string prefix format#38174Mason Daugherty (mdrxy) wants to merge 1 commit into
Conversation
…rmat Non-XML `get_buffer_string` dropped image/audio/video content blocks, losing references like image URLs the user explicitly mentioned. The prefix path now appends non-base64 image, audio, and video blocks as a human-readable reference (e.g. `[image: <url>]`) so all callers of the default format benefit. Plain string content and XML output are unchanged. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
get_buffer_string prefix formatget_buffer_string prefix format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change - v2 candidate
get_buffer_stringnow includes image/audio/video block references (e.g.[image: <url>]) in the default prefix format instead of dropping them.The default (non-XML)
get_buffer_stringonly kepttextcontent and silently dropped image, audio, and video blocks. That is lossy: a user who asks "what does this screenshot show?" with an attached image URL ends up with a summary that no longer references the image at all. Only theformat="xml"path preserved that information, so callers such asSummarizationMiddlewarehad to opt into XML to avoid the loss.This updates the shared utility so every caller of the default format benefits: non-base64
image,image_url(OpenAI-style),audio, andvideoblocks are appended as a concise human-readable reference. Plain string content and the XML format are unchanged, and base64/data:media is still omitted to avoid dumping payloads.Before / After
Given a multimodal
HumanMessage:Before (image URL silently dropped):
After (image reference preserved):
Made by Open SWE