fix(core): extract usage metadata from serialized tracer message outputs#35526
Merged
Conversation
Merging this PR will not alter performance
|
Hunter Lovell (hntrl)
previously approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes missing
run.metadata.usage_metadatapopulation inLangChainTracerfor real LLM/chat traces following #34414outputs.generations[*][*].message.kwargs.usage_metadatamessage.usage_metadata) from extractor to match real tracer output pathon_chat_model_start+ sharedon_llm_end) to reduce ambiguityWhy
#34414 introduced usage duplication into
run.metadata.usage_metadata, but the extractor readmessage.usage_metadata.In real tracer flow, messages are serialized with
dumpd(...)during run completion, so usage metadata lives undermessage.kwargs.usage_metadata. Because of this mismatch, duplication did not trigger in real traces.