Skip to content

fix(core): prevent async task garbage collection (RUF006) #34238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mason Daugherty (mdrxy) merged 4 commits into from
Dec 8, 2025
+5 −3
Merged

fix(core): prevent async task garbage collection (RUF006) #34238

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d8433e
fix(core): prevent async task garbage collection (RUF006)
MirrorDNA-Reflection-Protocol Dec 7, 2025
3bb5756
Merge branch 'master' into fix/core-async-gc-ruf006
mdrxy Dec 8, 2025
5aaa88b
Merge branch 'master' into fix/core-async-gc-ruf006
mdrxy Dec 8, 2025
07a1f42
Update libs/core/langchain_core/language_models/llms.py
mdrxy Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libs/core/langchain_core/language_models/llms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@

logger = logging.getLogger(__name__)

_background_tasks: set[asyncio.Task] = set()

Copilot AI Dec 8, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation for _background_tasks is incomplete. Since asyncio.Task is a generic type, it should include a type parameter. Consider using set[asyncio.Task[Any]] to properly type-hint the set of tasks with their return types.

Copilot generated this review using guidance from repository custom instructions.


@functools.lru_cache
def _log_error_once(msg: str) -> None:
Expand Down Expand Up @@ -100,9 +102,9 @@ def _before_sleep(retry_state: RetryCallState) -> None:
asyncio.run(coro)
else:
if loop.is_running():
# TODO: Fix RUF006 - this task should have a reference
# and be awaited somewhere
loop.create_task(coro) # noqa: RUF006
task = loop.create_task(coro)
_background_tasks.add(task)
task.add_done_callback(_background_tasks.discard)
Comment thread
mdrxy marked this conversation as resolved.
else:
asyncio.run(coro)
except Exception as e:
Expand Down