chore(core): improve typing of messages utils functions#34225
Merged
Mason Daugherty (mdrxy) merged 2 commits intoDec 8, 2025
Conversation
|
|
||
| # test explicitly excluding all tool calls | ||
| actual = filter_messages(messages, exclude_tool_calls={"1", "2"}) | ||
| actual = filter_messages(messages, exclude_tool_calls=["1", "2"]) |
Collaborator
Author
There was a problem hiding this comment.
It found some incorrect typing 😃
CodSpeed Performance ReportMerging #34225 will not alter performanceComparing
|
d06f642 to
8740ee2
Compare
|
|
||
| def test_trim_messages_bad_token_counter() -> None: | ||
| trimmer = trim_messages(max_tokens=10, token_counter={}) | ||
| trimmer = trim_messages(max_tokens=10, token_counter={}) # type: ignore[call-overload] |
Collaborator
Author
There was a problem hiding this comment.
There is now typing for _runnable_support annotated method args.
8740ee2 to
c35c6b7
Compare
c35c6b7 to
cb51436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we get the correct types for
_runnable_supportannotated functions.