chore(core): remove arg types from docstrings#33388
Merged
Mason Daugherty (mdrxy) merged 1 commit intoOct 9, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #33388 will improve performances by 18.12%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_import_time[BaseChatModel] |
562.5 ms | 495.9 ms | +13.44% |
| ⚡ | WallTime | test_import_time[ChatPromptTemplate] |
631 ms | 564.3 ms | +11.82% |
| ⚡ | WallTime | test_import_time[Document] |
231.8 ms | 208.7 ms | +11.07% |
| ⚡ | WallTime | test_import_time[InMemoryVectorStore] |
679.2 ms | 590.8 ms | +14.97% |
| ⚡ | WallTime | test_import_time[LangChainTracer] |
455.2 ms | 412.1 ms | +10.47% |
| ⚡ | WallTime | test_import_time[PydanticOutputParser] |
567.8 ms | 507 ms | +12.01% |
| ⚡ | WallTime | test_import_time[RunnableLambda] |
545.5 ms | 461.8 ms | +18.12% |
| ⚡ | WallTime | test_import_time[Runnable] |
514.1 ms | 463.5 ms | +10.92% |
Footnotes
-
21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
75dceec to
d04d87b
Compare
d04d87b to
40d5a9f
Compare
Mason Daugherty (mdrxy)
approved these changes
Oct 9, 2025
Member
Mason Daugherty (mdrxy)
left a comment
There was a problem hiding this comment.
LGTM. We can also remove Defaults to None. or Defaults to x in all cases where the default is defined in the signature, but that can come in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kwargsby**kwargswhen needed