Skip to content

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Aug 4, 2025

No description provided.

Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Aug 19, 2025 3:36pm

Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed WallTime Performance Report

Merging #32386 will not alter performance

Comparing cbornet:mypy-strict-cli (0ccbb2e) with master (02d6b91)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Instrumentation Performance Report

Merging #32386 will not alter performance

Comparing cbornet:mypy-strict-cli (0ccbb2e) with master (02d6b91)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy added the linting Linting, formatting, or typing label Aug 4, 2025
@cbornet cbornet requested a review from Copilot August 12, 2025 09:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables strict mypy type checking for the CLI package by updating the mypy configuration and fixing type annotations throughout the codebase.

  • Enables strict mypy checking with additional error codes and warnings
  • Fixes generic type annotations to be more specific (e.g., dictdict[str, Any])
  • Adds missing return type annotations and improves type import handling

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/cli/pyproject.toml Enables strict mypy checking and updates mypy version constraint
libs/cli/tests/unit_tests/test_utils.py Fixes generic dict type annotation and adds Any import
libs/cli/scripts/generate_migrations.py Makes output parameter optional in function signature
libs/cli/langchain_cli/utils/git.py Specifies dict type with string keys and Any values
libs/cli/langchain_cli/project_template/app/server.py Adds return type annotation to async function
libs/cli/langchain_cli/namespaces/migrate/main.py Updates type ignore comment for untyped import
libs/cli/langchain_cli/namespaces/migrate/generate/utils.py Specifies list type annotation for imports attribute

strict = "True"
strict_bytes = "True"
enable_error_code = "deprecated"
warn_unreachable = "True"
Copy link
Preview

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boolean values in TOML should be unquoted. Use strict = true instead of strict = "True".

Suggested change
warn_unreachable = "True"
strict = true
strict_bytes = true
enable_error_code = "deprecated"
warn_unreachable = true

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mdrxy mdrxy self-assigned this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting Linting, formatting, or typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants