add support for doctrine/dbal ^3.2 #5
Conversation
XilefNori
force-pushed
the
feature/DMS-1137
branch
from
e3b89df to
a66709f
Compare
.gitignore
Outdated
| @@ -1,3 +1,5 @@ | |||
| .idea | |||
There was a problem hiding this comment.
please store this in local global gitignore
| @@ -63,7 +63,7 @@ public function isEnumNameTypeMapping(): bool | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function convertToPHPValue($value, AbstractPlatform $platform) | |||
| public function convertToPHPValue($value, AbstractPlatform $platform): ?Enum | |||
There was a problem hiding this comment.
I'm not sure whether this work if doctrine/dbal project introduce signatures on their classes at some point. I think we should avoid this at the moment for interfaces\overrides\etc
There was a problem hiding this comment.
They already did: it is already marked as "mixed" in 3.3
https://github.com/doctrine/dbal/blob/3.3.x/src/Types/Type.php#L83 in PHPDoc typehint
and it will be real mixed in 4.x:
https://github.com/doctrine/dbal/blob/4.0.x/src/Types/Type.php#L87
There was a problem hiding this comment.
Good point. Did a verification test, looks OK https://3v4l.org/DLWKM
| @@ -13,7 +13,7 @@ final class EnumTypeInitializer | |||
| * @param NamingStrategyInterface|null $strategy | |||
| * @param bool $enumNameTypeMapping | |||
| * | |||
| * @throws \Doctrine\DBAL\DBALException | |||
| * @throws \Doctrine\DBAL\Exception | |||
There was a problem hiding this comment.
there is no such exception in doctrine/dbal: ^2, but we still allow it
There was a problem hiding this comment.
Yes there is. Starting from 2.11, that is why ^2.11
https://github.com/doctrine/dbal/blob/2.11.0/lib/Doctrine/DBAL/Exception.php
There was a problem hiding this comment.
👍 Tag sorting confused me. v2.10.2 is top in tag list for me, checked that one
XilefNori
force-pushed
the
feature/DMS-1137
branch
from
a66709f to
58e4afa
Compare
Exception replacement is "mandatory" as PHPDoc can be mandatory.
|
|
Thanks @XilefNori! |
No description provided.