Fix doctrine type mapping and sql declaration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaytrase
suggested changes
May 20, 2019
src/DBAL/EnumType.php
Outdated
| @@ -81,12 +81,18 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform) | |||
| /** {@inheritdoc} */ | |||
| public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform) | |||
| { | |||
| return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration); | |||
| return $this->name; | |||
There was a problem hiding this comment.
This change will break everything if there is no type alias present in database for this type
dedpikhto
force-pushed
the
fix-type-mapping-and-sql-declaration
branch
2 times, most recently
from
4f18a21 to
b69eff6
Compare
|
Review, please |
scaytrase
suggested changes
Aug 1, 2019
| if (isset($configs['enum_name_type_mapping'])) { | ||
| $enumNameTypeMapping = (bool)$configs['enum_name_type_mapping']; | ||
| } else { | ||
| $enumNameTypeMapping = false; |
There was a problem hiding this comment.
Already removed at all
| @@ -15,6 +15,9 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
|
|
|||
| $root = $builder->root('lamoda_enum'); | |||
|
|
|||
| $root->children()->scalarNode('enum_name_type_mapping') | |||
dedpikhto
force-pushed
the
fix-type-mapping-and-sql-declaration
branch
from
b69eff6 to
c226679
Compare
|
Thank you, @dedpikhto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.