When 2 boards are scoring concurrently the running scores reset to 501

[laingsimon]

On the live view.

Seems to be ok when only one board is scoring at a time.

• split out statements in useEffect into discrete functions and reduce nesting
• add test to verify issue
• alter lastIncompleteMatch (if this is the cause of the fault)

[laingsimon]

There must be a match otherwise the live display wouldn't show. Therefore the issue appears to stem from

courage_scores/CourageScores/ClientApp/src/components/sayg/LiveSuperleagueTournamentDisplay.tsx

Lines 328 to 335 in 3cbe572

	function currentScore(leg: LegDto, side: SideType) {
	const startingScore = leg.startingScore || 501;
	const accumulator: LegCompetitorScoreDto = leg[side];
	return (
	startingScore -
	getScoreFromThrows(startingScore, accumulator.throws || [])
	);
	}

The accumulator must have a value, but if throws or its scores are empty/undefined then the result will be the same as the startingScore or 501

courage_scores/CourageScores/ClientApp/src/helpers/sayg.ts

Lines 55 to 66 in 3cbe572

	export function getScoreFromThrows(
	startingScore: number,
	throws?: LegThrowDto[],
	): number {
	return (throws || []).reduce(
	(total: number, thr: LegThrowDto) =>
	total + (thr.score || 0) > startingScore
	? total /* bust */
	: total + (thr.score || 0),
	0,
	);
	}

[laingsimon]

Found an issue where a subscription can splat over another if they're requested concurrently. This is likely not the same underlying cause but it is something that needs fixing.

Current plan for a solution is to ensure the subscription requests are 'queued' in the LiveContainer, they're currently processed on-demand (and in this case in parallel)