[Add] custom time stamp format #1046 #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
=========================================
+ Coverage 78.92% 79% +0.07%
=========================================
Files 27 27
Lines 1879 1881 +2
=========================================
+ Hits 1483 1486 +3
+ Misses 282 281 -1
Partials 114 114
Continue to review full report at Codecov.
|
vishr
requested changes
Feb 18, 2018
middleware/logger.go
Outdated
| @@ -46,7 +46,8 @@ type ( | |||
| // Example "${remote_ip} ${status}" | |||
| // | |||
| // Optional. Default value DefaultLoggerConfig.Format. | |||
| Format string `yaml:"format"` | |||
| Format string `yaml:"format"` | |||
| CustomTimestampFormat string `yaml:"custom_timestamp_format"` | |||
There was a problem hiding this comment.
- Let's call this property as
CustomTimeFormat - Put a line break between
FormatandCustomTimeFormatproperties and add a comment - Include this tag (
time_custom) in the list of tags at the end of time tags
There was a problem hiding this comment.
Thank you for your kind advise :)
I have fixed what you pointed out, so pls review!
|
@airKing05 thanks for your contribution 🎉 |
This was referenced Feb 19, 2018
vishr
pushed a commit
that referenced
this pull request
Mar 12, 2018
Enhancements:
Implemented Response#After()
Dynamically add/remove proxy targets
Rewrite rules for proxy middleware
Add ability to extract key from a form field
Implemented rewrite middleware
Adds a separate flag for the 'http/https server started on' message (#1043)
Applied a little DRY to the redirect middleware (#1053) and tests (#1055)
Simplify dep fetching (#1062)
Add custom time stamp format #1046 (#1066)
Update property name & default value & comment about custom logger
Add X-Requested-With header constant
Return error of context.File in c.contentDisposition
Updated deps
Updated README.md
Fixes:
Fixed Response#Before()
Fixed #990
Fix href url from armor to echo (#1051)
Fixed #1054
Fixed #1052, dropped param alias feature
Avoid redirect loop in HTTPSRedirect middleware (#1058)
Fix deferring body close in middleware/compress test (#1063)
Cleanup code (#1061)
FIX - We must close gzip.Reader, only if no error (#1069)
Fix formatting (#1071)
Can be a fix for auto TLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! :)
This PR is related to #1046 .
Custom time stamp format and some tests is added to this branch.
I would like you to review.
thanks.