feat: Add flag config to store stat data into Redis or no #5051
+417
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:L
Co-authored-by: octodog <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -606,50 +626,40 @@ | |||
| async def batch_load_live_stat( | |||
| cls, ctx: GraphQueryContext, agent_ids: Sequence[str] | |||
| ) -> Sequence[Any]: | |||
| async def _pipe_builder(r: Redis): | |||
| pipe = r.pipeline() | |||
| # TODO: make it work | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @property | ||
| def _metric_query_endpoint(self) -> yarl.URL: | ||
| metric_query_addr = self._config_provider.config.metric.address.to_legacy() | ||
| return yarl.URL(f"http://{metric_query_addr}/api/v1") |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
| metric_name: str, | ||
| label: DeviceMetricOptionalLabel, | ||
| ) -> UtilizationMetricType: | ||
| # TODO: Define device metadata for each metric and use it rather than hardcoding |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
HyeockJinKim
reviewed
Jul 9, 2025
Comment on lines
+647
to
+660
| async def _pipe_builder(r: Redis): | ||
| pipe = r.pipeline() | ||
| for agent_id in agent_ids: | ||
| await pipe.get(agent_id) | ||
| return pipe | ||
|
|
||
| return ret | ||
| ret = [] | ||
| for stat in await redis_helper.execute(ctx.redis_stat, _pipe_builder): | ||
| if stat is not None: | ||
| ret.append(msgpack.unpackb(stat, ext_hook_mapping=msgpack.uuid_to_str)) | ||
| else: | ||
| ret.append(None) | ||
|
|
||
| @classmethod | ||
| async def batch_load_cpu_cur_pct( | ||
| cls, ctx: GraphQueryContext, agent_ids: Sequence[str] | ||
| ) -> Sequence[Any]: | ||
| ret = [] | ||
| for stat in await cls.batch_load_live_stat(ctx, agent_ids): | ||
| if stat is not None: | ||
| try: | ||
| ret.append(float(stat["node"]["cpu_util"]["pct"])) | ||
| except (KeyError, TypeError, ValueError): | ||
| ret.append(0.0) | ||
| else: | ||
| ret.append(0.0) | ||
| return ret | ||
| return ret |
There was a problem hiding this comment.
This part may need to be added to the valkey client implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5027 (BA-1802)
Checklist: (if applicable)
ai.backend.testdocsdirectory