Skip to content

feat(BA-1755): Add ModelVFolderTemplate (WIP) #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ai/backend/test/templates/vfolder/model_vfolder.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ async def _context(self) -> AsyncIterator[None]:
try:
vfolder = await client_session.VFolder.create(
name=vfolder_name,
group=vfolder_cfg.group,
unmanaged_path=vfolder_cfg.unmanaged_path,
permission=vfolder_cfg.permission,
usage_mode="model",
Expand Down
35 changes: 35 additions & 0 deletions src/ai/backend/test/templates/vfolder/model_vfolder_fixtures.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
MODEL_SERVER_FIXTURE = """\
from http.server import BaseHTTPRequestHandler, HTTPServer

class HealthCheckHandler(BaseHTTPRequestHandler):
def do_GET(self):
if self.path == '/health':
self.send_response(200)
self.end_headers()
self.wfile.write(b'OK')
else:
self.send_response(404)
self.end_headers()

def run(server_class=HTTPServer, handler_class=HealthCheckHandler, port=8000):
server_address = ('', port)
httpd = server_class(server_address, handler_class)
httpd.serve_forever()

if __name__ == '__main__':
run()
"""

MODEL_DEFINITION_FIXTURE = """\
models:
- name: "test-server"
model_path: "/models"
service:
start_command:
- python
- server.py
port: 8000
health_check:
path: /health
max_retries: 5
"""
26 changes: 23 additions & 3 deletions src/ai/backend/test/testcases/model_service/testspecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,18 @@
PublicEndpointTemplate,
)
from ai.backend.test.templates.model_service.jwt_token import ModelServiceTokenTemplate
from ai.backend.test.templates.vfolder.file_uploader import PlainTextFilesUploader
from ai.backend.test.templates.vfolder.model_vfolder import ModelVFolderTemplate
from ai.backend.test.templates.vfolder.model_vfolder_fixtures import (
MODEL_DEFINITION_FIXTURE,
MODEL_SERVER_FIXTURE,
)
from ai.backend.test.testcases.model_service.health_check import (
EndpointHealthCheck,
EndpointHealthCheckWithToken,
)
from ai.backend.test.testcases.spec_manager import TestSpec, TestTag
from ai.backend.test.tester.dependency import ClusterDep
from ai.backend.test.tester.dependency import ClusterDep, UploadFileDep

from ...templates.template import BasicTestTemplate

Expand All @@ -38,14 +44,28 @@
# Endpoint health check failure is expected.
template=BasicTestTemplate(
EndpointHealthCheck(expected_status_codes={400, 401})
).with_wrappers(KeypairAuthTemplate, EndpointTemplate),
).with_wrappers(
KeypairAuthTemplate, ModelVFolderTemplate, PlainTextFilesUploader, EndpointTemplate
),
parametrizes={
ContextName.CLUSTER_CONFIG: [
ClusterDep(
cluster_mode=ClusterMode.SINGLE_NODE,
cluster_size=1,
),
]
],
ContextName.VFOLDER_UPLOAD_FILES: [
[
UploadFileDep(
path="model-definition.yaml",
content=MODEL_DEFINITION_FIXTURE,
),
UploadFileDep(
path="server.py",
content=MODEL_SERVER_FIXTURE,
),
]
],
},
),
"single_node_single_container_creation_public_endpoint_success": TestSpec(
Expand Down
Loading