Skip to content

fix(BA-1520): Restrict setting ResourceLimit below the resource label (WIP) #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(BA-1520): Restrict setting ResourceLimit below the resource label (WIP) #4841

wants to merge 1 commit into from
+27 −1

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Jun 25, 2025 •
edited
Loading

resolves #NNN (BA-1520)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added size:S 10~30 LoC comp:manager Related to Manager component comp:common Related to Common component labels Jun 25, 2025
@jopemachine jopemachine changed the title fix: Restrict setting ResourceLimit below the resource label (WIP) fix(BA-1520): Restrict setting ResourceLimit below the resource label (WIP) Jun 25, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 25, 2025
View reviewed changes
src/ai/backend/manager/services/image/service.py
to_update.get("_resources", {}).get(label_key, {}).get("min", None)
)

# TODO: Consider slot types

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@jopemachine jopemachine

Labels
comp:common Related to Common component comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jopemachine