feat: Add rate limiting for computing kernel creation #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
fregataa
changed the title
fregataa
changed the title
|
Added an "on-hold" label to this PR and converted this to a draft because we suspected that too few DB connections were causing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2952
Add rate limiting for computing kernel creation. The number of kernels that can be created within a single scheduler tick is now capped by a shared config value.
The value is saved in shared config(etcd) and the key of config value is
config/session/max-num-kernel-to-create. The default value is null, which does not limit the number of kernels created in a single tick.Checklist: (if applicable)