Skip to content
This repository was archived by the owner on Sep 22, 2023. It is now read-only.

Conversation

adrysn
Copy link
Member

@adrysn adrysn commented Apr 13, 2020

This pull-request adds usage_mode and permission parameter in creating and querying virtual folder. Type is changed into Ownership Type for query result.

Those fields are to be introduced in lablup/backend.ai-manager#265.

@adrysn adrysn added the feature label Apr 13, 2020
@adrysn adrysn added this to the 20.03 milestone Apr 13, 2020
@adrysn adrysn requested a review from achimnol April 13, 2020 07:17
@adrysn adrysn self-assigned this Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.00%.
The diff coverage is 37.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   40.85%   40.85%           
=======================================
  Files          59       59           
  Lines        5701     5705    +4     
=======================================
+ Hits         2329     2331    +2     
- Misses       3372     3374    +2     
Impacted Files Coverage Δ
src/ai/backend/client/func/vfolder.py 71.21% <ø> (ø)
src/ai/backend/client/cli/vfolder.py 29.80% <37.50%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef944b4...21472ae. Read the comment docs.

@achimnol
Copy link
Member

Please update the branch to resolve conflicts. Check out #97 to what have been changed.

@achimnol achimnol merged commit 240fea1 into master Apr 27, 2020
@achimnol achimnol deleted the feature/extended-vfolder-options branch April 27, 2020 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants