-
Notifications
You must be signed in to change notification settings - Fork 205
Fix docker conditional import for tests #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix docker conditional import for tests #1655
Conversation
0fdd961
to
47f0f3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1655 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 170 170
Lines 13389 13389
======================================
Hits 7473 7473
Misses 5916 5916
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@b2vn could you give this a spin? I currently do not have a docker setup. |
f03b75e
to
f0b672a
Compare
I saw this and gave it a test. Is this what you needed @Emantor ? Running tests without the
And with:
|
This way we can correctly skip the tests if the module is not available, otherwise we gat a ModuleNotFoundError because of the unconditional docker import. Signed-off-by: Rouven Czerwinski <[email protected]>
f0b672a
to
3f1c6c0
Compare
Description
This way we can correctly skip the tests if the module is not available,
otherwise we gat a ModuleNotFoundError because of the unconditional
docker import.
Checklist