Conversation
kulp
force-pushed
the
build-in-cmake
branch
3 times, most recently
from
9864708 to
d05df56
Compare
kulp
force-pushed
the
build-in-cmake
branch
2 times, most recently
from
9107ad6 to
8c770bc
Compare
kulp
force-pushed
the
build-in-cmake
branch
3 times, most recently
from
d8da1fe to
35f4f34
Compare
Codecov Report
@@ Coverage Diff @@
## develop #97 +/- ##
=========================================
- Coverage 96.2% 96.1% -0.2%
=========================================
Files 34 35 +1
Lines 2667 2707 +40
Branches 470 0 -470
=========================================
+ Hits 2568 2602 +34
- Misses 76 105 +29
+ Partials 23 0 -23
Continue to review full report at Codecov.
|
kulp
force-pushed
the
build-in-cmake
branch
4 times, most recently
from
5fb2b0c to
ca4d4e4
Compare
Remove gzip and zip packaging rules
Remove obsoleted JIT-only flag
Drop doc and usage_% rules
Drop distclean target
Drop clobber rules
Drop old check_{sw,test} rules
Drop MEMCHECK option
Remove obsoleted runwrap and build_t*
Remove MAKESTEP
Drop -fsanitize=* support
Drop support for debug builds
Remove install-related targets
Remove install_sdl.sh
Remove EXE_SUFFIX
Drop obsoleted PLATFORM variable
Drop showbuilddir target
Remove 32-bit build support
Drop coverage support
We will reconstruct coverage support appear the CMake build appears.
Configure tenyr_config.h
This is not as nice as using SDL2 cmake files directly, and it will reinstitute a Homebrew dependency. Revisit this.
This BSD-licensed third-party [coverage module][1] for CMake will help restore the coverage capability that was removed in fc6572c. [1]: https://github.com/bilke/cmake-modules/blob/d98828f54f6974717798e63195cfbf08fe2daad0/CodeCoverage.cmake
This plays badly with the CodeCoverage.cmake inclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to strip out whatever functionality of the old (Make-based) build is not tested in CI (such as the
installrule), as well as some functionality that is tested in CI (such as thecoveragerule), and rebuilds functionality in CMake.