Skip to content

Fix crash in SDLVGA on macOS Big Sur 11.2#83

Merged
kulp merged 1 commit intodevelopfrom
sdl-fix
Mar 20, 2021
Merged

Fix crash in SDLVGA on macOS Big Sur 11.2#83
kulp merged 1 commit intodevelopfrom
sdl-fix

Conversation

@kulp
Copy link
Copy Markdown
Owner

@kulp kulp commented Mar 20, 2021

On macOS Big Sur 11.2, a crash in sdlvga (but not sdlled) was noticed when running SDL with a non-dummy display. The underlying cause is not fully understood, but the new call order is consistent with the pre-existing call order in handle_update.

On macOS Big Sur 11.2, a crash in sdlvga (but not sdlled) was noticed when
running SDL with a non-dummy display. The underlying cause is not fully
understood, but the new call order is consistent with the pre-existing call
order in handle_update.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2021

Codecov Report

Merging #83 (c7a97f9) into develop (763ca54) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #83   +/-   ##
=======================================
  Coverage     96.6%   96.6%           
=======================================
  Files           35      35           
  Lines         2652    2652           
  Branches       468     468           
=======================================
  Hits          2563    2563           
  Misses          70      70           
  Partials        19      19           
Impacted Files Coverage Δ
src/devices/sdlvga.c 90.1% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763ca54...c7a97f9. Read the comment docs.

@kulp kulp merged commit 92e41fa into develop Mar 20, 2021
@kulp kulp deleted the sdl-fix branch March 20, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant