Conversation
Codecov Report
@@ Coverage Diff @@
## develop #47 +/- ##
=========================================
+ Coverage 87.5% 88.9% +1.4%
=========================================
Files 34 34
Lines 2810 2707 -103
Branches 504 484 -20
=========================================
- Hits 2459 2409 -50
+ Misses 186 142 -44
+ Partials 165 156 -9
Continue to review full report at Codecov.
|
kulp
force-pushed
the
simplify
branch
4 times, most recently
from
edebbfd to
a3a3a0e
Compare
This comment has been minimized.
This comment has been minimized.
kulp
force-pushed
the
simplify
branch
2 times, most recently
from
6c48a6f to
98d200c
Compare
kulp
force-pushed
the
simplify
branch
2 times, most recently
from
46c7ada to
4acee91
Compare
The forth half-implementation, such as it was, was highly bitrotted, and philosophically unsound (Forth words were being implemented in terms of assembly tokens rather than in terms of text, with no end in sight). A Forth implementation would be a delightful thing for tenyr to have, and surely someday it will have one, but carrying around a partial implementation that does not do anything useful except survive assembly is not a good way to prepare for tenyr v1.0.
We never actually tested on a DE0, and we should not pretend we have long-term robust support for closed-source EDA toolchains.
The `@+` syntax is much used, but `@=` has never been so.
The only VHDL files we ever really used were third-part files for VGA output, which were removed in 27ca05c -- but those files used the `.vhd` extension and were not buildable by these rules anyway. There are no plans for tenyr to use VHDL any time soon, so we can remove this functionality for now.
The build "infrastructure" for generating such devices on demand was never really warranted.
The web demo is a desirable feature, and may return someday, but its maintenance burden is not defensible for 1.0. On the other hand, building for node.js (via asm.js or wasm) is a valuable capability that will be maintained for 1.0. Simplify use of preprocessor Stop embedding .th and resource files Drop tinypp The only need for the tiny C preprocessor was to support the web demo, which has been removed. Drop (unused, non-working) SDL support under emscripten Remove ui/web and disperse its contents Stop using MODULARIZE
for f in test/misc/obj/*.to ; do tld -o $f.new $f && mv $f.new $f ; done Manually update version to 2 in other test objs
There is no point in supporting v0 and v1 objects for tenyr v1.0. They can still be recognized and thrown away, but we can freely consider them to be error cases at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some parts of tenyr's "ecosystem" are less vibrant than others. Namely, the Forth implementation has bitrotted from what was never a really functional capability to begin with, and some parts of the hardware implementation could be shed, too.
The current PR bids adieu to a few of these less-than-maintained vestiges of a more ambitious era in order to pave the way for a meaningful v1.0 release.