Add explicit activesupport dependency#208
Merged
krororo merged 1 commit intokufu:masterfrom Jul 1, 2025
Merged
Conversation
Previously, this gem relied on activesupport that was implicitly included through the activerecord dependency. Since we directly require "active_support/core_ext/time/calculations" and use `ActiveSupport::Concern` and `ActiveSupport::CurrentAttributes`, we should declare an explicit dependency. While it's unlikely that activesupport will be removed from activerecord's dependencies, we should have an explicit dependency since this gem uses it directly.
lighty
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit activesupport dependency.
Previously, this gem relied on activesupport that was implicitly included through the activerecord dependency.
Since we directly require "active_support/core_ext/time/calculations" and use
ActiveSupport::ConcernandActiveSupport::CurrentAttributes, we should declare an explicit dependency.While it's unlikely that activesupport will be removed from activerecord's dependencies, we should have an explicit dependency since this gem uses it directly.