Skip to content

Update README as within_deleted and without_deleted are deprecated#178

Merged
krororo merged 1 commit intokufu:masterfrom
krororo:update-readme
Sep 17, 2024
Merged

Update README as within_deleted and without_deleted are deprecated#178
krororo merged 1 commit intokufu:masterfrom
krororo:update-readme

Conversation

@krororo
Copy link
Copy Markdown
Collaborator

@krororo krororo commented Sep 16, 2024

README was out of date, so it was updated.

  • within_deleted and without_deleted are deprecated. Using ignore_transaction_datetime is preferred.
  • Fixed incorrect query for transaction_at.
  • Fixed typo in description

@krororo krororo marked this pull request as ready for review September 16, 2024 10:02
@auto-assign auto-assign bot requested review from mkmn and yono September 16, 2024 10:02
@krororo krororo requested a review from osyo-manga September 16, 2024 10:02
osyo-manga
osyo-manga approved these changes Sep 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@osyo-manga osyo-manga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krororo krororo merged commit 5289f74 into kufu:master Sep 17, 2024
@krororo krororo deleted the update-readme branch September 17, 2024 00:07
@wata727 wata727 mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osyo-manga osyo-manga osyo-manga approved these changes

@mkmn mkmn Awaiting requested review from mkmn

@yono yono Awaiting requested review from yono

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krororo @osyo-manga