Skip to content

Do not run CI against rails_main#166

Merged
wata727 merged 1 commit intokufu:masterfrom
wata727:remove_main_from_ci
Jun 5, 2024
Merged

Do not run CI against rails_main#166
wata727 merged 1 commit intokufu:masterfrom
wata727:remove_main_from_ci

Conversation

@wata727
Copy link
Copy Markdown
Contributor

@wata727 wata727 commented Jun 5, 2024

Currently, we run CI against the rails_main on every PR, but unfortunately we don't have time to fix the failed tests right away.

This PR proposes removing the CI for the rails_main, since unfixed falling tests are confusing.

@auto-assign auto-assign bot requested review from krororo and lighty June 5, 2024 03:04
@wata727 wata727 requested review from kumaie-shr and osyo-manga and removed request for lighty June 5, 2024 03:04
@krororo
Copy link
Copy Markdown
Collaborator

krororo commented Jun 5, 2024

I would like to see this removed as well.

appraise "rails-main" do
gem "rails", git: 'https://github.com/rails/rails.git', branch: "main"
end

@wata727 wata727 force-pushed the remove_main_from_ci branch from 0807682 to 2381eec Compare June 5, 2024 04:54
@wata727
Copy link
Copy Markdown
Contributor Author

wata727 commented Jun 5, 2024

Copy link
Copy Markdown
Collaborator

@krororo krororo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Copy Markdown
Contributor

@kumaie-shr kumaie-shr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@wata727 wata727 merged commit 0211fdd into kufu:master Jun 5, 2024
@wata727 wata727 deleted the remove_main_from_ci branch June 5, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants