Fix deleted time order between associations

[wata727]

This PR fixes a strange problem with deletion times when deleting a model with a Bi-Temporal model association with dependent: :destroy.

Normally, when an association is deleted by dependent: :destroy, it is deleted before its parent by before_destroy callback.
https://github.com/rails/rails/blob/v7.1.3/activerecord/lib/active_record/associations/builder/association.rb#L141

However, strangely, the bitemporal gem creates a history where the parent is deleted first:

employee = Employee.create(name: "John", address: Address.new(city: "Tokyo"))
emplpyee.destroy!

employee.valid_at(employee.address.valid_to) { |e| e.reload } # => ActiveRecord::RecordNotFound

Why does this happen? The cause is the timing of calculating the operation time. ActiveRecord::Bitemporal::Persistence#destroy is assigned the time when it is called as operated_at:

activerecord-bitemporal/lib/activerecord-bitemporal/bitemporal.rb

Line 347 in 21420ef

def destroy(force_delete: false, operated_at: Time.current)

On the other hand, the callback fires inside the destroy method:

activerecord-bitemporal/lib/activerecord-bitemporal/bitemporal.rb

Line 356 in 21420ef

_run_destroy_callbacks {

This causes the actual deletion to occur from child to parent, but the operation time is calculated from parent to child.

This PR fixes the problem by calculating the operation time inside the destroy callback.

[wata727]

This description is already does not represent the actual scenario, so I have revised it.
Perhaps the description no longer matches what has already been tested in #19.

[krororo]

🚀

[Dooor]

🙆