Skip to content

Don't use appraisal in CI#145

Merged
krororo merged 1 commit intokufu:masterfrom
krororo:dont-use-appraisal-in-ci
Aug 17, 2023
Merged

Don't use appraisal in CI#145
krororo merged 1 commit intokufu:masterfrom
krororo:dont-use-appraisal-in-ci

Conversation

@krororo
Copy link
Copy Markdown
Collaborator

@krororo krororo commented Aug 7, 2023

Use the BUNDLE_GEMFILE environment variable to simplify running bundle install.

@auto-assign auto-assign bot requested review from QWYNG and osyo-manga August 7, 2023 01:09
Copy link
Copy Markdown
Contributor

@QWYNG QWYNG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@krororo Are you going to delete files related to appraisal?

@krororo
Copy link
Copy Markdown
Collaborator Author

krororo commented Aug 9, 2023

@QWYNG

Are you going to delete files related to appraisal?

No, I think appraisal will continue to be useful to manage multiple gemfiles.

Copy link
Copy Markdown
Contributor

@mkmn mkmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krororo
Copy link
Copy Markdown
Collaborator Author

krororo commented Aug 17, 2023

Thanks!

@krororo krororo merged commit dc38488 into kufu:master Aug 17, 2023
@krororo krororo deleted the dont-use-appraisal-in-ci branch August 17, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants