Change not to create history when destroying with force_update

[wata727]

This PR changes the destroy behavior on force_update. Previously, when destroying, the state before destruction was added as history.

employee = Employee.create!
employee.destroy!

puts ActiveRecord::Bitemporal::Visualizer.visualize(employee)

# transaction_datetime    | valid_datetime
#                         | 2023-06-27 16:23:24.487
#                         |                   | 2023-06-27 16:23:52.387
#                         |                   |                   | 9999-12-31 09:00:00.000
# 2023-06-27 16:23:24.487 +---------------------------------------+
#                         |                                       |
#                         |                                       |
#                         |                                       |
#                         |                                       |
# 2023-06-27 16:23:52.387 +-------------------+-------------------+
#                         |*******************|
#                         |*******************|
#                         |*******************|
#                         |*******************|
# 9999-12-31 09:00:00.000 +-------------------+

After this change, destruction performed within force_update will no longer create history.

employee = Employee.create!
employee.force_update { employee.destroy! }

puts ActiveRecord::Bitemporal::Visualizer.visualize(employee)

# transaction_datetime    | valid_datetime
#                         | 2023-06-27 08:42:13.857
#                         |                                       | 9999-12-31 00:00:00.000
# 2023-06-27 08:42:13.857 +---------------------------------------+
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
#                         |***************************************|
# 2023-06-27 08:42:26.857 +---------------------------------------+

This is an application of force_update's "operate without saving history" property to destruction.

This is useful for destruction without history if you accidentally creates a record. This is equivalent to update_columns(transaction_to: Time.current), but is implemented as an Active Record interface to benefit from standard mechanisms such as callbacks.

[krororo]

It looks like ignore_bitemporal_datetime can be used.

Suggested change

	it { expect { subject }.not_to change { Employee.ignore_valid_datetime.within_deleted.count } }
	it { expect { subject }.not_to change { Employee.ignore_bitemporal_datetime.count } }

[wata727]

Makes sense. But ignore_valid_datetime.within_deleted is the standard way in the spec.
https://github.com/search?q=repo%3Akufu%2Factiverecord-bitemporal+ignore_valid_datetime.within_deleted&type=code

It would be nice to replace them all in someday.

[krororo]

I made a nits comment, but it looks good.

[Dooor]

👍