Skip to content

Bump up version to v4.0.0#128

Merged
Dooor merged 1 commit intokufu:masterfrom
Dooor:release/4_0_0
Mar 1, 2023
Merged

Bump up version to v4.0.0#128
Dooor merged 1 commit intokufu:masterfrom
Dooor:release/4_0_0

Conversation

@Dooor
Copy link
Copy Markdown
Contributor

@Dooor Dooor commented Feb 28, 2023

Changelog

4.0.0

Breaking Changed

Added

  • Add support bitemporal_callbacks #123

    class Employee < ActiveRecord::Base
      include ActiveRecord::Bitemporal
    
      after_bitemporal_create :log_create
      after_bitemporal_update :log_update
      after_bitemporal_destroy :log_destroy
    
      private
      
      def log_create
        puts "employee created"
      end
    
      def log_update
        puts "employee updated"
      end
    
      def log_destroy
        puts "employee destroyed"
      end
    end
    
    employee = Employee.create!(...) # => "employee created"
    employee.update!(...) # => "employee updated"
    employee.destroy! # => "employee destroyed"

Changed

Deprecated

Removed

Fixed

@auto-assign auto-assign bot requested review from QWYNG and mkmn February 28, 2023 12:11
@mkmn
Copy link
Copy Markdown
Contributor

mkmn commented Feb 28, 2023

I would like to add a pull request that is not listed in CHANGELOG.
v3.0.0...Dooor:release/4_0_0

#115
#125
#124
#126

@Dooor Dooor force-pushed the release/4_0_0 branch 2 times, most recently from 787161a to 6bce4f4 Compare February 28, 2023 12:34
@Dooor Dooor requested review from krororo and osyo-manga February 28, 2023 12:35
Copy link
Copy Markdown
Contributor

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

CHANGELOG.md Outdated
### Removed

- [Remove Gemfile.lock #126](https://github.com/kufu/activerecord-bitemporal/pull/126)
- [Drop support Rails 5.2 #122](https://github.com/kufu/activerecord-bitemporal/pull/122)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, supported version changes (#122 #125) are classified as breaking changes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I modified it.

Copy link
Copy Markdown
Contributor

@mkmn mkmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Member

@motsat motsat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Collaborator

@krororo krororo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Copy Markdown
Collaborator

@osyo-manga osyo-manga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Dooor Dooor merged commit 4188244 into kufu:master Mar 1, 2023
@Dooor Dooor deleted the release/4_0_0 branch March 1, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants