Add support changing swapped_id, when called # destroy.#110
Merged
motsat merged 2 commits intokufu:masterfrom Jan 11, 2023
Merged
Add support changing swapped_id, when called # destroy.#110motsat merged 2 commits intokufu:masterfrom
# destroy.#110motsat merged 2 commits intokufu:masterfrom
Conversation
wata727
reviewed
Dec 23, 2022
| } | ||
| raise ActiveRecord::RecordInvalid unless @destroyed | ||
|
|
||
| @_swapped_id = duplicated_instance.swapped_id |
Contributor
There was a problem hiding this comment.
Is the swapped_id be assigned when after_destroy is called?
Intuitively, after_destroy is called after _run_destroy_callback, it seems that the swapped_id is not assigned at that time.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated after
#destroybut notswapped_id.As a use case, I'm thinking of referencing swapped_id in the destroyed model callback(after_destroy) and saving it to another table.