fix: add client certs for image registry#3122
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request introduces the generation and usage of dedicated client certificates (image-registry-client.crt and image-registry-client.key) for the image registry, replacing the previous use of the server-side certificates for client authentication. This includes updating the certificate generation tasks, default configuration paths, precheck tasks, and documentation. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
052467d to
a90b866
Compare
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
a90b866 to
7041d8f
Compare
|



What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously, the image registry client reused the server certificates (
image_registry.crtandimage_registry.key) for mTLS authentication with the registry, which is not best practice and may cause certificate verification issues in certain scenarios.This PR makes the following changes:
image-registry-client.crtandimage-registry-client.key) during the cert initialization phase, with CN set toimage-registry-client.image_registry.auth.cert_fileandkey_filefrom server certificates to the newly generated client certificates.docs/en/reference/config.mdanddocs/zh/config/reference/config.md).Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: