Skip to content

fix: extraArgs should be map[string]string#3116

Merged
ks-ci-bot merged 1 commit into
kubesphere:mainfrom
redscholar:some_bug
May 28, 2026
Merged

fix: extraArgs should be map[string]string#3116
ks-ci-bot merged 1 commit into
kubesphere:mainfrom
redscholar:some_bug

Conversation

@redscholar

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

extraArgs should be map[string]string

Additional documentation, usage docs, etc.:


Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@kubesphere-prow kubesphere-prow Bot added kind/bug Categorizes issue or PR as related to a bug. release-note labels May 28, 2026
@kubesphere-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kubernetes kubeadm initialization templates (kubeadm-init.v1beta3 and kubeadm-init.v1beta4) by wrapping boolean and integer values (such as profiling, service-account-lookup, audit-log-maxbackup, and terminated-pod-gc-threshold) in double quotes to ensure they are treated as strings. I have no feedback to provide as there are no review comments to address.

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@ks-ci-bot ks-ci-bot merged commit 8cd89f5 into kubesphere:main May 28, 2026
4 checks passed
@redscholar redscholar deleted the some_bug branch May 28, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants