Skip to content

fix: miss auth plain_http#3109

Merged
ks-ci-bot merged 1 commit into
kubesphere:mainfrom
redscholar:miss_auth_plain_http
May 21, 2026
Merged

fix: miss auth plain_http#3109
ks-ci-bot merged 1 commit into
kubesphere:mainfrom
redscholar:miss_auth_plain_http

Conversation

@redscholar

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

miss auth's arg in task ImageRegistry | Push images package to image registry

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

miss auth plain_http

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow Bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels May 21, 2026
@kubesphere-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the image registry push task to use dynamic variables for skip_tls_verify and plain_http instead of a hardcoded value. The review feedback points out that quoting these boolean values in the template may cause unmarshaling errors and suggests providing default values to ensure the template renders correctly.

Comment thread builtin/core/roles/image-registry/push/tasks/main.yaml Outdated
@redscholar redscholar force-pushed the miss_auth_plain_http branch from 9e8688d to 1e35f00 Compare May 21, 2026 08:54
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@redscholar redscholar force-pushed the miss_auth_plain_http branch from 1e35f00 to 9a35bbd Compare May 21, 2026 08:56
@sonarqubecloud

Copy link
Copy Markdown

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@ks-ci-bot ks-ci-bot merged commit c2775d3 into kubesphere:main May 21, 2026
4 checks passed
@redscholar redscholar deleted the miss_auth_plain_http branch May 21, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants