fix: miss auth plain_http#3109
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the image registry push task to use dynamic variables for skip_tls_verify and plain_http instead of a hardcoded value. The review feedback points out that quoting these boolean values in the template may cause unmarshaling errors and suggests providing default values to ensure the template renders correctly.
9e8688d to
1e35f00
Compare
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
1e35f00 to
9a35bbd
Compare
|



What type of PR is this?
/kind bug
What this PR does / why we need it:
miss auth's arg in task
ImageRegistry | Push images package to image registryWhich issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: