fix: generate manifest clear#3108
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the IsEnabled logic in taggable.go to explicitly handle the NeverTag constant and refines Ansible task tagging in the core defaults. It also introduces conditional spiderpool_version logic in the manifests template. Feedback identifies a typo in a newly added comment and recommends making the spiderpool_version configurable through the context instead of using a hardcoded value, which aligns with the configuration pattern used for other components in the file.
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
a8219b4 to
0b31b9a
Compare
|



What type of PR is this?
/kind bug
What this PR does / why we need it:
the manifests.yaml only generate at
kk artifact exportandkk artifact images --pullWhich issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: