Skip to content

fix: generate manifest clear#3108

Merged
ks-ci-bot merged 1 commit into
kubesphere:mainfrom
redscholar:generate_manifest
May 21, 2026
Merged

fix: generate manifest clear#3108
ks-ci-bot merged 1 commit into
kubesphere:mainfrom
redscholar:generate_manifest

Conversation

@redscholar

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

the manifests.yaml only generate at kk artifact export and kk artifact images --pull

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

generate manifest clear

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow Bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels May 21, 2026
@kubesphere-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IsEnabled logic in taggable.go to explicitly handle the NeverTag constant and refines Ansible task tagging in the core defaults. It also introduces conditional spiderpool_version logic in the manifests template. Feedback identifies a typo in a newly added comment and recommends making the spiderpool_version configurable through the context instead of using a hardcoded value, which aligns with the configuration pattern used for other components in the file.

Comment thread builtin/core/roles/defaults/templates/manifests.yaml Outdated
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@redscholar redscholar force-pushed the generate_manifest branch from a8219b4 to 0b31b9a Compare May 21, 2026 08:46
@sonarqubecloud

Copy link
Copy Markdown

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@ks-ci-bot ks-ci-bot merged commit f8966ec into kubesphere:main May 21, 2026
7 checks passed
@redscholar redscholar deleted the generate_manifest branch May 21, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants