Skip to content

fix: correct boolean default value handling in templates#3076

Merged
kubesphere-prow[bot] merged 1 commit into
kubesphere:mainfrom
redscholar:default_true
Apr 21, 2026
Merged

fix: correct boolean default value handling in templates#3076
kubesphere-prow[bot] merged 1 commit into
kubesphere:mainfrom
redscholar:default_true

Conversation

@redscholar

@redscholar redscholar commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@kubesphere-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow Bot added do-not-merge/release-note-label-needed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none labels Apr 21, 2026
@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the handling of boolean flags in templates, specifically for TLS verification and storage class enablement, by moving away from the default filter in favor of explicit key checking or direct property access. It also introduces default storage class configurations for local and NFS providers and removes redundant conditional checks in task execution. I have no feedback to provide.

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2026
@kubesphere-prow kubesphere-prow Bot merged commit 5c01859 into kubesphere:main Apr 21, 2026
4 checks passed
@redscholar redscholar deleted the default_true branch April 21, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant