fix: remove image_registry tags from binary tasks#3066
Conversation
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There was a problem hiding this comment.
Code Review
This pull request introduces a conditional default registry for the 'cn' zone, setting it to hub.kubesphere.com.cn. It also removes the 'image_registry' tags from various binary download tasks in the Ansible roles and deletes the '--with-kubernetes' flag from the artifact image CLI options. I have no feedback to provide as there are no review comments.



What type of PR is this?
/kind bug
What this PR does / why we need it:
when run
kk artifact imagesit should not download binaryWhich issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: