Skip to content

fix: remove image_registry tags from binary tasks#3066

Merged
yongchuanzhou merged 1 commit into
kubesphere:mainfrom
redscholar:artifact-image
Apr 9, 2026
Merged

fix: remove image_registry tags from binary tasks#3066
yongchuanzhou merged 1 commit into
kubesphere:mainfrom
redscholar:artifact-image

Conversation

@redscholar

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

when run kk artifact images it should not download binary

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

remove image_registry tags from binary tasks

Additional documentation, usage docs, etc.:


Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@kubesphere-prow kubesphere-prow Bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels Apr 9, 2026
@kubesphere-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a conditional default registry for the 'cn' zone, setting it to hub.kubesphere.com.cn. It also removes the 'image_registry' tags from various binary download tasks in the Ansible roles and deletes the '--with-kubernetes' flag from the artifact image CLI options. I have no feedback to provide as there are no review comments.

@yongchuanzhou yongchuanzhou merged commit acd50ab into kubesphere:main Apr 9, 2026
6 of 7 checks passed
@redscholar redscholar deleted the artifact-image branch April 9, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants