Skip to content

Update containerd test based on new bootstrapping logic. #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Apr 17, 2018
Merged

Update containerd test based on new bootstrapping logic. #7739

k8s-ci-robot merged 1 commit into from
Apr 17, 2018

Conversation

@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Apr 17, 2018

Depends on containerd/cri#740.

/hold
Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2018
krzyzacy
krzyzacy approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

BenTheElder
BenTheElder approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/shrug
@krzyzacy should we move these to --env flags?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

BenTheElder commented Apr 17, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krzyzacy
Copy link
Member

krzyzacy commented Apr 17, 2018

/this-is-fine
also scalability folks are making more common env files...

I'll say let's just wait until we move all the envs to prow

@krzyzacy
Copy link
Member

krzyzacy commented Apr 17, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit b572f0b into kubernetes:master Apr 17, 2018
@Random-Liu Random-Liu deleted the update-containerd-test branch April 17, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

+1 more reviewer

@krzyzacy krzyzacy krzyzacy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenTheElder BenTheElder

@krzyzacy krzyzacy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Random-Liu @k8s-ci-robot @BenTheElder @krzyzacy