Skip to content

fix(dns): preserve pod names in histogram rows - #4202

Open
immanuwell wants to merge 1 commit into
kubernetes:masterfrom
immanuwell:fix/dns-histogram-pod-name
Open

fix(dns): preserve pod names in histogram rows#4202
immanuwell wants to merge 1 commit into
kubernetes:masterfrom
immanuwell:fix/dns-histogram-pod-name

Conversation

@immanuwell

@immanuwell immanuwell commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Keeps pod_name on DNS histogram rows.

The default client deployment has 4 pods. With --db, histogram rows got a NULL pod name, so joins with result rows duplicated data

Repro: run cd dns && python py/run_perf.py --dns-server coredns --params params/coredns/test.yaml --db out/db, then join histograms and results on run and subrun.
Before this fix, every histogram row joins to every client result row

Test: make verify-all-dev and DNS Python unit tests

Signed-off-by: immanuwell <pchpr.00@list.ru>
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: immanuwell
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from bowei and shyamjvs July 21, 2026 05:59
@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @immanuwell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2026
@immanuwell

Copy link
Copy Markdown
Contributor Author

@bowei @shyamjvs please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant