fix(dns): preserve pod names in histogram rows - #4202
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: immanuwell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Keeps
pod_nameon DNS histogram rows.The default client deployment has 4 pods. With
--db, histogram rows got a NULL pod name, so joins with result rows duplicated dataRepro: run
cd dns && python py/run_perf.py --dns-server coredns --params params/coredns/test.yaml --db out/db, then joinhistogramsandresultson run and subrun.Before this fix, every histogram row joins to every client result row
Test:
make verify-all-devand DNS Python unit tests