Add custom resource LIST benchmark scenario - #4160
Conversation
|
Welcome @yuminn-k! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuminn-k The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @yuminn-k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
request: Can we make the CRD larger, like much larger. We'd like to be able to catch things like kubernetes/kubernetes#136950 (comment). Create something similar to that size |
40efd6a to
0dfc10a
Compare
|
Thanks for the pointer. I rebased the PR on current master and updated the custom-resource benchmark to use a larger, Kueue-like nested CRD schema and custom resource shape instead of the previous single payload string. I also moved the custom-resource LIST load into its own sequential benchmark segment so it does not run mixed with the configmap segment. Validation after the update:
|
What type of PR is this?
/kind feature
/sig api-machinery
What this PR does / why we need it:
Adds an optional Custom Resource LIST scenario to the existing ClusterLoader2
testing/listbenchmark.The scenario is disabled by default and can be enabled with
CL2_LIST_CUSTOM_RESOURCE_NUMBER. When enabled, it:ListBenchmarkResourceCRD for the benchmark,Which issue(s) this PR fixes:
Part of kubernetes/kubernetes#130169.
Special notes for your reviewer:
This focuses on the custom-resource slice of kubernetes/kubernetes#130169 and is rebased on top of the Pods LIST benchmark that is now in
master.AI disclosure: This PR was prepared in part with the assistance of an AI coding assistant. I reviewed the generated changes, understand the code being submitted, and verified it with the tests listed below.
Validation:
go test ./api ./pkg/config ./pkg/testfromclusterloader2passes.git diff --checkpasses.CL2_LIST_CUSTOM_RESOURCE_NUMBER=1renders the CRD, custom-resource, custom-resource lister, and cleanup steps.CL2_LIST_CUSTOM_RESOURCE_NUMBER=1 CL2_LIST_POD_NUMBER=1renders the custom-resource segment followed by the pod segment.kubectl apply --dry-run=serveragainst a local kind apiserver.