Fix insecure max bind port value to 65535 for scheduler & apiserver#79346
Merged
Conversation
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
Member
Author
|
@sttts you want a release note? |
Member
Author
|
/assign @wojtek-t |
Member
|
Great catch, @ncdc! |
Contributor
|
/lgtm |
ravisantoshgudimetla
approved these changes
Jun 24, 2019
ravisantoshgudimetla
left a comment
Contributor
There was a problem hiding this comment.
/lgtm
Thanks for the fix @ncdc
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, ravisantoshgudimetla, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/cc @yliaog |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Correct the maximum bind port value to 65535 for the insecure ports for kube-scheduler and apiserver (it was 65335, which is 200 less than what it should be).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: