Skip to content

aws: Remove ALBTargetControlConfig CRD from LBC manifest#18233

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
rifelpet:lbc-skip
Apr 24, 2026
Merged

aws: Remove ALBTargetControlConfig CRD from LBC manifest#18233
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
rifelpet:lbc-skip

Conversation

@rifelpet
Copy link
Copy Markdown
Member

@rifelpet rifelpet commented Apr 23, 2026

The E2E suite runs a test that requires the ALBTargetControlAgent=true feature gate. The test is skipped based on the presence of this CRD and the upstream helm chart doesn't offer a way to not render it, so we delete it here instead.

Once the feature gate defaults to enabled we can revert this.

This is an effort towards fixing this failing e2e job: https://testgrid.k8s.io/kops-misc#kops-aws-aws-load-balancer-controller

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2026
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus April 23, 2026 23:12
@k8s-ci-robot k8s-ci-robot requested a review from zetaab April 23, 2026 23:12
@rifelpet
Copy link
Copy Markdown
Member Author

/test pull-kops-e2e-aws-load-balancer-controller

@rifelpet
Copy link
Copy Markdown
Member Author

Only one test is failing now 👍🏻

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Apr 24, 2026

/override pull-kops-e2e-aws-load-balancer-controller

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-load-balancer-controller

Details

In response to this:

/override pull-kops-e2e-aws-load-balancer-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 07058d8 into kubernetes:master Apr 24, 2026
30 checks passed
@hakman hakman changed the title Remove ALBTargetControlConfig CRD from LBC manifest aws: Remove ALBTargetControlConfig CRD from LBC manifest Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants