Skip to content

gce: use set type where order does not matter #17377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gce: use set type where order does not matter #17377

wants to merge 2 commits into from
+245 −227

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Apr 27, 2025 •
edited
Loading

Starting small with FirewallRule Allowed and SourceRanges fields,
but this should be easier than explicitly handling values
where order does not matter.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from hakman April 27, 2025 19:02
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from johngmyers April 27, 2025 19:02
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2025
@justinsb justinsb force-pushed the use_set_type_for_implicit_normalization branch from deff2da to 93e782b Compare April 27, 2025 19:32
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2025
@justinsb justinsb added this to the v1.33 milestone Apr 27, 2025
justinsb added 2 commits April 28, 2025 10:29
@justinsb
gce: use set type where order does not matter
d264354 
Starting small with FirewallRule Allowed and SourceRanges,
but this should be easier than explicitly handling values
where order does not matter.
@justinsb
autogen: update expected output for Set[string] changes
ee0b15b
@justinsb justinsb force-pushed the use_set_type_for_implicit_normalization branch from 93e782b to ee0b15b Compare April 28, 2025 14:36
@justinsb
Copy link
Member Author

justinsb commented Apr 28, 2025 •
edited
Loading

(This isn't urgent, I think this is a nice-to-have to address this problem going forwards, we can discuss in office hours)

Note one (negative?) consequence of this is that the rules are string-sorted in terraform. I think that's a good thing going forwards, but it will cause a text-level diff in the terraform output (though not a cloud-level diff, because terraform also knows order doesn't matter here)

@hakman
Copy link
Member

hakman commented Apr 28, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-cilium ee0b15b link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-gce-ipalias ee0b15b link true /test pull-kops-e2e-k8s-gce-ipalias

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees
No one assigned
Labels
area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @k8s-ci-robot @hakman @k8s-triage-robot