-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Docs: Improve opentelemetry-trust-incoming-span
.
#13606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Improve opentelemetry-trust-incoming-span
.
#13606
Conversation
The committers listed above are authorized under a signed CLA. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @adamvr! |
Hi @adamvr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
opentelemetry-trust-incoming-span
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind documentation
/priority backlog
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adamvr, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.13 |
/cherry-pick release-1.12 |
@Gacko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #13636 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #13637 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR updates the documentation for the
nginx.ingress.kubernetes.io/opentelemetry-trust-incoming-span
ingress annotation. Specifically:nginx.ingress.kubernetes.io/enable-opentelemetry
We were assuming that since
enable-opentelemetry
was enabled on the ingress controller we didn't need to set it in the ingress annotations as well, but no you need both.Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: