Use x/tools/go/packages

[vincepri]

To better support modules, we should plan to switch to the x/tools/go/package library to scan Go packages.

This issue is a follow up from https://github.com/kubernetes/code-generator/issues/69.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[nikhita]

/remove-lifecycle stale

…

On Mon, Sep 23, 2019 at 7:55 PM fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-testing, kubernetes/test-infra and/or fejta <https://github.com/fejta>. /lifecycle stale — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#147?email_source=notifications&email_token=AD24BUCH6FOJWIAZ7ESN35LQLDGWRA5CNFSM4H3IMNX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7LBDDI#issuecomment-534122893>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD24BUAHT66EVMTQGDZJQD3QLDGWRANCNFSM4H3IMNXQ> .

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vincepri]

/lifecycle frozen

[tbe]

I would like to implement this.

As i see it for now, this would replace most of

• addDir
• importBuildPackage
• importPackage
• findTypesIn
• FindTypes

As we could get the types.Package object for each package during the initial packages.Load(), the FindTypes procedure would result very much in a stub (for compatibility) and the universe could be filled during the import phase.

Anything i got way off or missed?

[lavalamp]

I'd be happy to see this modernized. I don't have the cycles to help much, though.

[tbe]

I'll figure it out. I will try to leave exported functions at least functioning from user perspective as they do now. PR will be up in draft as soon as something working exists. Am 14. April 2020 23:42:34 MESZ schrieb Daniel Smith <notifications@github.com>:

…

I'd be happy to see this modernized. I don't have the cycles to help much, though. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #147 (comment)

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.