Skip to content

Conversation

@kahirokunn
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for kubernetes-sig-multicluster ready!

Name Link
🔨 Latest commit e5f3a1d
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sig-multicluster/deploys/697d528e5a33fc000899fe11
😎 Deploy Preview https://deploy-preview-44--kubernetes-sig-multicluster.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from munnerz and skitt January 29, 2026 09:34
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2026
@qiujian16
Copy link

This looks great, thanks!

@kahirokunn
Copy link
Member Author

I'm glad to hear you say that. Thank you😀

and the label `x-k8s.io/cluster-manager`). A cluster manager may use multiple internal controllers
or plugins to update different parts of `.status` (e.g. version, properties, conditions,
[accessProviders](https://github.com/kubernetes/enhancements/blob/master/keps/sig-multicluster/5339-clusterprofile-plugin-credentials/README.md));
when multiple actors write status, use [Server-Side Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need to specify the implementation detail to this level.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I included this because when I introduce the ClusterProfile API, people often ask “What is a cluster manager? Is it a controller? How do I build one?” and in our Slack thread opinions were divided. I wanted to give users a bit more of an idea of what a ClusterManager is and how it can be structured. I’m open to trimming the implementation detail or moving it elsewhere if you think that would work better.

@kahirokunn kahirokunn force-pushed the docs/cluster-manager branch from d271c7a to e5f3a1d Compare January 31, 2026 00:53
@kahirokunn kahirokunn changed the title docs: add ClusterManager implementation guidance and accessProviders to ClusterProfile API docs: add ClusterManager implementation guidance Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants