-
Notifications
You must be signed in to change notification settings - Fork 17
docs: add ClusterManager implementation guidance #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-sig-multicluster ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This looks great, thanks! |
|
I'm glad to hear you say that. Thank you😀 |
| and the label `x-k8s.io/cluster-manager`). A cluster manager may use multiple internal controllers | ||
| or plugins to update different parts of `.status` (e.g. version, properties, conditions, | ||
| [accessProviders](https://github.com/kubernetes/enhancements/blob/master/keps/sig-multicluster/5339-clusterprofile-plugin-credentials/README.md)); | ||
| when multiple actors write status, use [Server-Side Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we need to specify the implementation detail to this level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment. I included this because when I introduce the ClusterProfile API, people often ask “What is a cluster manager? Is it a controller? How do I build one?” and in our Slack thread opinions were divided. I wanted to give users a bit more of an idea of what a ClusterManager is and how it can be structured. I’m open to trimming the implementation detail or moving it elsewhere if you think that would work better.
Signed-off-by: kahirokunn <[email protected]>
d271c7a to
e5f3a1d
Compare
No description provided.