-
Notifications
You must be signed in to change notification settings - Fork 39
scripts for prow precommit and crd jobs #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts for prow precommit and crd jobs #47
Conversation
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
|
Welcome @olivercodes! |
astoycos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for tackling this!!! @olivercodes
This is almost there.
When I run locally I am running into some errors
[astoycos@localhost network-policy-api]$ make verify
hack/verify-all.sh -v
Skipping hack/../hack/verify-all.sh
Verifying gofmt
Test FAILED: hack/../hack/verify-gofmt.sh
level=warning msg="[linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
SUCCESS: hack/../hack/verify-golint.sh
Verifying govet
pattern ./...: lstat /home/astoycos/go/src/github.com/k8s.io/network-policy-api/cache/00/003426ff6eb11828a6df4b2609e8ee569ba24474bc5a96c630c74d47cf5ee675-a: permission denied
no Go files in /home/astoycos/go/src/github.com/k8s.io/network-policy-api
Test FAILED: hack/../hack/verify-govet.sh
make: *** [Makefile:41: verify] Error 1
|
/assign @tssurya As well if she has some extra time for a look |
|
woohoo thanks for your contribution @olivercodes!, we were just about to start on the CI parts for the repo and this is great a start, let me try to review this by end of this week. - first thing that came to my mind as I did an overall scroll was if you could squash the cleanup commits that would make history look cleaner.. |
95fbc77 to
7a16680
Compare
astoycos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olivercodes This is pretty much there!! Thanks again.
One last nit and also if you could just Sign-off your commit/s while you're at it that'd be awesome!
(I need to work on a contributor guidelines doc or point back to K8s's https://github.com/kubernetes/community/blob/master/contributors/devel/README.md#setting-up-your-dev-environment-coding-and-debugging in our readme)
Signed-off-by: Bryan Oliver <[email protected]>
7a16680 to
6e6b1a2
Compare
Fixed that last nit and squased |
|
Awesome!!! Great first Contribution :) Let's merge everything and see it all working! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, olivercodes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |

This is to resolve #37
After chatting with @astoycos we decided it would be better to follow what other sigs have done, and implement a prow job, as well as follow similar patterns for the test scripts (moving to live under hack/).
There will be a second PR for this issue, in test-infra to add the prow job that calls these changes.
p.s. This is my first PR to a kubernetes project, so I'm sure I did something wrong. Please feel free to tell me :).