Skip to content

Changes to implement option #2 for the port matching #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bowei wants to merge 2 commits into from
Closed

Changes to implement option #2 for the port matching #342

bowei wants to merge 2 commits into from

Conversation

@bowei
Copy link
Contributor

@bowei bowei commented Nov 7, 2025 •
edited
Loading

Example:

apiVersion: policy.networking.k8s.io/v1alpha2
kind: ClusterNetworkPolicy
metadata:
  name: port1
spec:
  tier: Admin
  priority: 0
  subject:
    namespaces:
      matchLabels:
        kubernetes.io/metadata.name: sensitive-ns
  ingress:
    - action: Deny
      name: select-all-deny-all
      from:
      - pods:
          namespaceSelector:
            matchLabels: {}
          podSelector:
            matchLabels: {}
      protocols:
        tcp:
          - destinationPort:
              number: 8080
              # flags: [syn] # future extension example
          - destinationPort:
              range:
                start: 8080
                end: 9090
        udp:
          - destinationPort:
              number: 8080
          - destinationPort:
              number: 9090
        destinationNamedPort:
          - name: http
          - name: monitoring

@netlify
Copy link

netlify bot commented Nov 7, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit f5ea69a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-network-policy-api/deploys/69240479ffba1a0008efe9eb
😎 Deploy Preview https://deploy-preview-342--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested a review from aojea November 7, 2025 23:10
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bowei
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from npinaeva November 7, 2025 23:10
@bowei bowei marked this pull request as draft November 7, 2025 23:10
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 7, 2025
@bowei bowei mentioned this pull request Nov 7, 2025
Merged
@bowei
Copy link
Contributor Author

bowei commented Nov 13, 2025

I am going to update this to match the NPEP.

bowei added 2 commits November 23, 2025 23:07
@bowei
Changes to implement option kubernetes-sigs#2 for the port matching
1ac0440 
kubernetes-sigs#297

protocols:
  tcp:
    - destinationPort:
        number: 8080
    - destinationPort:
        range:
          start: 8080
          end: 9090
  udp:
    - destinationPort:
        number: 8080
    - destinationPort:
        number: 9090
  destinationNamedPort:
    - name: http
    - name: monitoring
@bowei
Generated code from the API change
f5ea69a
@bowei bowei marked this pull request as ready for review November 24, 2025 07:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@bowei
Copy link
Contributor Author

bowei commented Nov 24, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025

@bowei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-network-policy-api-crd-e2e f5ea69a link true /test pull-network-policy-api-crd-e2e
pull-network-policy-api-verify f5ea69a link true /test pull-network-policy-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mikemorris mikemorris mentioned this pull request Nov 25, 2025
Merged
@danwinship
Copy link
Contributor

danwinship commented Dec 2, 2025 

      protocols:
        tcp:
          - destinationPort:
              number: 8080
              # flags: [syn] # future extension example
          - destinationPort:
              range:
                start: 8080
                end: 9090
        udp:
          - destinationPort:
              number: 8080
          - destinationPort:
              number: 9090

We noticed in the last meeting that this is kind of weird: the protocols struct fields have "OR" semantics, whereas in almost all other cases, struct fields have "AND" semantics.

It seems like it would be better to have protocols contain an array, and have "exactly one of" semantics for the elements of the array. This is probably equivalent to one of the earlier proposals which we rejected for some other reason?

@bowei
Copy link
Contributor Author

bowei commented Dec 2, 2025

Agreed that OR'ing across nested lists in structs is not most straightforward:

Specifically:

protocols:
  proto1:
    - <match1>
    - <match2>
  proto2:
    - <match1>
    - <match2>

Will be <proto1, match1> OR <proto1, match2> OR <proto2, match1> OR <proto2, match2>...

Whereas just saying "OR across this list of items":

protocols:
- proto1:
    <match1>
- proto1:
    <match2>
- proto2:
  ...

seems more understandable. (This option was covered in the big thread on Nadia's NPEP...)

Dyanngg
Dyanngg reviewed Dec 16, 2025
View reviewed changes
apis/v1alpha1/baselineadminnetworkpolicy_types.go
// Subject field.
type BaselineAdminNetworkPolicyIngressRule struct {
// Name is an identifier for this rule, that may be no more than 100 characters
// Name is an identifier for this rule, that may be no more than 100 charactersp
Copy link
Contributor

@Dyanngg Dyanngg Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Contributor Author

@bowei bowei Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

apis/v1alpha2/clusternetworkpolicy_types.go
// DestinationNamedPort selects a destination port on a pod based on the Container.Port
// name.
//
// This cannot be used this in a rule with Nodes or Networks peers, as they
Copy link
Contributor

@Dyanngg Dyanngg Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for this to be validated via CEL, or are implementations expected to validate this?

Copy link
Contributor Author

@bowei bowei Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will add CEL.

@bowei
Copy link
Contributor Author

bowei commented Dec 18, 2025

/close

shifting to option 3:

#347

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 18, 2025

@bowei: Closed this PR.

Details

In response to this:

/close

shifting to option 3:

#347

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dyanngg Dyanngg Dyanngg left review comments

@aojea aojea Awaiting requested review from aojea

@npinaeva npinaeva Awaiting requested review from npinaeva

@danwinship danwinship Awaiting requested review from danwinship

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bowei @k8s-ci-robot @danwinship @Dyanngg