Skip to content

Conversation

@tssurya
Copy link
Contributor

@tssurya tssurya commented Apr 13, 2025

  • We have three implementations: ovn-k, calico and kube-network-policies implementing this field, its been a year almost since we added networks. Time to graduate this to standard.
  • This was discussed and agreed at KubeCon EU

Depends on #284 going in first to avoid conflicts.

TODO: Think a bit more into maybe splitting that experimental CRD to have separate tests for nodes and networks? This is done.

go test  -v ./conformance -run TestConformanceProfiles -args --conformance-profiles=AdminNetworkPolicy,BaselineAdminNetworkPolicy --organization=ovn-org -project=ovn-kubernetes -url=blah -version=0.1.1 -contact=surya -additional-info=blah -supported-features=AdminNetworkPolicyEgressNodePeers,BaselineAdminNetworkPolicyEgressNodePeers,AdminNetworkPolicyNamedPorts,BaselineAdminNetworkPolicyNamedPorts

Closes #259

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2025
@netlify
Copy link

netlify bot commented Apr 13, 2025

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 41f89d0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6817a9399442810008c97fba
😎 Deploy Preview https://deploy-preview-296--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tssurya tssurya changed the title Graduate networks to standard [WIP] Graduate networks to standard Apr 13, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2025
@aojea
Copy link
Contributor

aojea commented Apr 13, 2025

ipv6 runners have a kernel bug actions/runner-images#11985 switch the image to ubuntu 24.04 meanwhile this is not solved

@aojea
Copy link
Contributor

aojea commented Apr 13, 2025

  • We have two implementations: ovn-k and calico implementing this field

three 😄 https://github.com/kubernetes-sigs/kube-network-policies/blob/88de1eb2d16f88e59ff9997bd6180f47042100c1/pkg/networkpolicy/networkpolicyapi.go#L55-L63

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@tssurya
Copy link
Contributor Author

tssurya commented May 1, 2025

@danwinship
Copy link
Contributor

needs rebase...

@tssurya tssurya force-pushed the graduate-networks-to-standard branch from 80cff31 to 170abeb Compare May 4, 2025 11:35
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 4, 2025
@tssurya tssurya force-pushed the graduate-networks-to-standard branch from 170abeb to 41f89d0 Compare May 4, 2025 17:51
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2025
@tssurya tssurya changed the title [WIP] Graduate networks to standard Graduate networks to standard May 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2025
@tssurya
Copy link
Contributor Author

tssurya commented May 5, 2025

@danwinship this one's ready for reviews

@danwinship
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 47a8507 into kubernetes-sigs:main May 6, 2025
10 checks passed
@tssurya tssurya mentioned this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graduating networks peer to standard channel from experimental

4 participants