Skip to content

Conversation

@tssurya
Copy link
Contributor

@tssurya tssurya commented Sep 23, 2023

Sample Output for Conformance Reports:

=== NAME  TestConformanceProfiles
    conformance_profile_test.go:142: Conformance report:
        apiVersion: policy.networking.k8s.io/v1alpha1
        date: "2023-10-19T19:03:23+02:00"
        implementation:
          additionalInformation: "https://github.com/ovn-org/ovn-kubernetes/blob/e0d2ab8afd043a03c6e6b2935a0d773810dad0f7/test/conformance/network_policy_v2_test.go#L50"
          contact:
          - '@tssurya'
          organization: ovn-org
          project: ovn-kubernetes
          url: https://github.com/ovn-org/ovn-kubernetes
          version: 0.1.1
        kind: ConformanceReport
        networkPolicyV2APIVersion: v0.1.2
        profiles:
        - core:
            result: success
            statistics:
              Failed: 0
              Passed: 7
              Skipped: 0
            summary: ""
          name: AdminNetworkPolicy
        - core:
            result: success
            statistics:
              Failed: 0
              Passed: 7
              Skipped: 0
            summary: ""
          name: BaselineAdminNetworkPolicy

How to run tests in profiles mode?

go test  -v ./conformance -run TestConformanceProfiles -args --conformance-profiles=AdminNetworkPolicy,BaselineAdminNetworkPolicy --organization=ovn-org -project=ovn-kubernetes -url="https://github.com/ovn-org/ovn-kubernetes" -version=0.1.1 -contact=@tssurya -additional-info="blah"

Related to #137

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2023
@tssurya tssurya force-pushed the implement-conformance-profiles branch from 6bf5c61 to 193554b Compare October 3, 2023 05:59
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 7e9c9b4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/653165f36e7380000864efc3
😎 Deploy Preview https://deploy-preview-142--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tssurya tssurya force-pushed the implement-conformance-profiles branch from 193554b to d595bdf Compare October 3, 2023 06:24
@tssurya tssurya marked this pull request as ready for review October 3, 2023 06:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from astoycos October 3, 2023 06:24
@tssurya tssurya force-pushed the implement-conformance-profiles branch 3 times, most recently from aeee1bb to 3f4e986 Compare October 3, 2023 07:36
@tssurya
Copy link
Contributor Author

tssurya commented Oct 3, 2023

/area conformance

@k8s-ci-robot k8s-ci-robot added the area/conformance Issues or PRs related to conformance testing label Oct 3, 2023
@tssurya tssurya force-pushed the implement-conformance-profiles branch 3 times, most recently from a3f92fb to 4611358 Compare October 3, 2023 08:09
@tssurya tssurya force-pushed the implement-conformance-profiles branch 2 times, most recently from 1ced07c to d4de3e9 Compare October 19, 2023 17:18
- bumps golang to 1.20
- bumps dependencies to 1.28
- gets the new sets pkg

Signed-off-by: Surya Seetharaman <[email protected]>
@tssurya tssurya force-pushed the implement-conformance-profiles branch from d4de3e9 to 7e9c9b4 Compare October 19, 2023 17:22
@tssurya
Copy link
Contributor Author

tssurya commented Oct 19, 2023

@Dyanngg : PTAL!
I am super interested to see if you can pull these changes in, bring up an antrea cluster, point the KUBECONFIG to it and then run:

go test  -v ./conformance -run TestConformanceProfiles -args --conformance-profiles=AdminNetworkPolicy,BaselineAdminNetworkPolicy --organization=ovn-org -project=ovn-kubernetes -url="https://github.com/ovn-org/ovn-kubernetes" -version=0.1.1 -contact=@tssurya -additional-info="blah"

something like that how does your test report look?

@Dyanngg
Copy link
Contributor

Dyanngg commented Oct 19, 2023

@Dyanngg : PTAL! I am super interested to see if you can pull these changes in, bring up an antrea cluster, point the KUBECONFIG to it and then run:
go test -v ./conformance -run TestConformanceProfiles -args --conformance-profiles=AdminNetworkPolicy,BaselineAdminNetworkPolicy --organization=ovn-org -project=ovn-kubernetes -url="https://github.com/ovn-org/ovn-kubernetes" -version=0.1.1 -contact=@tssurya -additional-info="blah"
something like that how does your test report look?

Pretty much the same results:

=== NAME  TestConformanceProfiles
    conformance_profile_test.go:142: Conformance report:
        apiVersion: policy.networking.k8s.io/v1alpha1
        date: "2023-10-19T13:52:40-07:00"
        implementation:
          additionalInformation: blah
          contact:
          - '@dyanngg'
          organization: antrea.io
          project: antrea
          url: https://github.com/antrea-io/antrea
          version: v1.13
        kind: ConformanceReport
        networkPolicyV2APIVersion: v0.1.2
        profiles:
        - core:
            result: success
            statistics:
              Failed: 0
              Passed: 7
              Skipped: 0
            summary: ""
          name: AdminNetworkPolicy
        - core:
            result: success
            statistics:
              Failed: 0
              Passed: 7
              Skipped: 0
            summary: ""
          name: BaselineAdminNetworkPolicy

Although tbh I feel like the addtionalInfo section is a bit unclear/unstructured at this point. We might want to take a look around and see if there's a standardized way where CI info can be passed, i.e. maybe a struct that supports mainstream CIs like github action/jenkins/argo etc.

@tssurya
Copy link
Contributor Author

tssurya commented Oct 20, 2023

Although tbh I feel like the addtionalInfo section is a bit unclear/unstructured at this point. We might want to take a look around and see if there's a standardized way where CI info can be passed, i.e. maybe a struct that supports mainstream CIs like github action/jenkins/argo etc.

I understand and agree fully. Let me open an issue to track this for us to do better moving forward. String is too loose ended.

@tssurya
Copy link
Contributor Author

tssurya commented Oct 20, 2023

Opened #160 to fix additional info field

Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@astoycos
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, Dyanngg, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astoycos
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit f7e9b37 into kubernetes-sigs:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to conformance testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants