Skip to content

🐛 fix: (helm/v1alpha1): add missing replicas field to the Deployment generated #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

🐛 fix: (helm/v1alpha1): add missing replicas field to the Deployment generated #4356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ metadata:
{{ "{{- include \"chart.labels\" . | nindent 4 }}" }}
control-plane: controller-manager
spec:
replicas: {{ "{{ .Values.controllerManager.replicas }}" }}
selector:
matchLabels:
{{ "{{- include \"chart.selectorLabels\" . | nindent 6 }}" }}
Expand Down
4 changes: 2 additions & 2 deletions pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/values.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ func (f *HelmValues) SetTemplateDefaults() error {

const helmValuesTemplate = `# [MANAGER]: Manager Deployment Configurations
controllerManager:
replicas: 1
container:
image:
repository: controller
tag: latest
replicas: 1
args:
- "--leader-elect"
- "--metrics-bind-address=:8443"
Expand Down Expand Up @@ -128,7 +128,7 @@ metrics:
{{ if .Webhooks }}
# [WEBHOOKS]: Webhooks configuration
# The following configuration is automatically generated from the manifests
# generated by controller-gen. To update run 'make manifests' and
# generated by controller-gen. To update run 'make manifests' and
# the edit command with the '--force' flag
webhook:
enable: true
Expand Down
1 change: 1 addition & 0 deletions testdata/project-v4-with-plugins/dist/chart/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ metadata:
{{- include "chart.labels" . | nindent 4 }}
control-plane: controller-manager
spec:
replicas: {{ .Values.controllerManager.replicas }}
selector:
matchLabels:
{{- include "chart.selectorLabels" . | nindent 6 }}
Expand Down
4 changes: 2 additions & 2 deletions testdata/project-v4-with-plugins/dist/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# [MANAGER]: Manager Deployment Configurations
controllerManager:
replicas: 1
container:
image:
repository: controller
tag: latest
replicas: 1
args:
- "--leader-elect"
- "--metrics-bind-address=:8443"
Expand Down Expand Up @@ -68,7 +68,7 @@ metrics:

# [WEBHOOKS]: Webhooks configuration
# The following configuration is automatically generated from the manifests
# generated by controller-gen. To update run 'make manifests' and
# generated by controller-gen. To update run 'make manifests' and
# the edit command with the '--force' flag
webhook:
enable: true
Expand Down
Loading