Skip to content

Conversation

@BenTheElder
Copy link
Member

ahead of v0.31.0 later today as discussed with co-maintainers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2025
@stmcginnis
Copy link
Contributor

/lgtm
/approve
/hold

Just holding in case we want to check anything out closer.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, stmcginnis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,stmcginnis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

BenTheElder commented Dec 18, 2025

oh right, cgroupv1 CI is failing because cgroupv1 isn't supported by default in Kubernetes in 1.35+

we should add a prominent release note about this

it is expected that kind by default will not support cgroup v1 now due to kubernetes's change for this, and in the near future we will drop support entirely to go along with this and focus our efforts
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2025
- template: fedora
provider: podman
rootless: rootless
# AlmaLinux 8 is used for testing kind with cgroup v1.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@BenTheElder
Copy link
Member Author

OK, this passes all the github actions, which are what tests the node image.

We removed the cgroup v1 action, but we care more about providing 1.35 OOTB that cgroup v1 support, and I'd rather not employ special workarounds because frankly this is the opportunity we need to drop v1 support while that is coordinated ecosystem wide rather than just being us.

@BenTheElder
Copy link
Member Author

this is a blocker for v0.31, and I've discussed merging this for 0.31 and the problem with cgroup v1 with sean already but he had to head out

@BenTheElder BenTheElder merged commit 32124c6 into kubernetes-sigs:main Dec 18, 2025
20 of 29 checks passed
@BenTheElder BenTheElder deleted the 135 branch December 18, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants