-
Notifications
You must be signed in to change notification settings - Fork 1.7k
bump node image to 1.35.0 #4077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/lgtm Just holding in case we want to check anything out closer. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
oh right, cgroupv1 CI is failing because cgroupv1 isn't supported by default in Kubernetes in 1.35+ we should add a prominent release note about this |
it is expected that kind by default will not support cgroup v1 now due to kubernetes's change for this, and in the near future we will drop support entirely to go along with this and focus our efforts
|
New changes are detected. LGTM label has been removed. |
| - template: fedora | ||
| provider: podman | ||
| rootless: rootless | ||
| # AlmaLinux 8 is used for testing kind with cgroup v1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/hold cancel |
|
OK, this passes all the github actions, which are what tests the node image. We removed the cgroup v1 action, but we care more about providing 1.35 OOTB that cgroup v1 support, and I'd rather not employ special workarounds because frankly this is the opportunity we need to drop v1 support while that is coordinated ecosystem wide rather than just being us. |
|
this is a blocker for v0.31, and I've discussed merging this for 0.31 and the problem with cgroup v1 with sean already but he had to head out |
ahead of v0.31.0 later today as discussed with co-maintainers