-
Notifications
You must be signed in to change notification settings - Fork 560
Docs/gamma glossary #3830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Docs/gamma glossary #3830
Conversation
updated the service-mesh link form glossary to GAMMA glossary
Removed the glossary section and moved it to the GAMMA section. Retitled it as GAMMA glossary. Refactored the links.
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Hackmey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Hackmey! |
Hi @Hackmey. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[north/south traffic]:concepts/glossary.md#northsouth-traffic | ||
[east/west traffic]:concepts/glossary.md#eastwest-traffic | ||
[gateway controller]:concepts/glossary.md#gateway-controller | ||
[north/south traffic]:mesh/gamma-glossary.md#northsouth-traffic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we mean to move north/south traffic under mesh glossary? @candita
[north/south traffic]:../concepts/glossary.md#northsouth-traffic | ||
[service mesh]:../concepts/glossary.md#service-mesh | ||
[east/west traffic]:../concepts/glossary.md#eastwest-traffic | ||
[north/south traffic]:gamma-glossary.md#northsouth-traffic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment here
@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: clarifications, for. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @Hackmey, thanks for looking into reorganizing things! I'm the one who originally committed the glossary. 🙂 It was definitely not meant to just be a mesh thing – is there a problem you're trying to solve with the move? |
geps/gep-1619/index.md
Outdated
@@ -813,7 +813,7 @@ might not function as expected. In such cases, it's acceptable to make appropria | |||
|
|||
The object of the [GAMMA (Gateway API for Mesh Management and Administration)](../../mesh/gamma.md) | |||
initiative is to provide support for service mesh and mesh-adjacent use-cases with Gateway API. GAMMA is focused on | |||
defining how Gateway API could also be used for inter-service or [east/west](../../concepts/glossary.md#eastwest-traffic) | |||
defining how Gateway API could also be used for inter-service or [east/west](../../site-src/mesh/gamma-glossary.md#eastwest-traffic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
site-src
will be something that shouldn't leak into URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated the file based on your suggestion. Let me know if it looks good now! Appreciate the feedback 🙏
Hi @kflynn, thanks for the clarification! I’m still pretty new and just following along to learn more. I saw the issue and realized I had a similar reaction, some of the glossary terms felt mesh-related, so I wasn’t sure how they applied to Gateways or xRoutes. Your explanation helps clear that up! If any changes are needed to make it clearer for new folks, I’d be happy to help with that. Just let me know what would be most useful. |
So I think the right thing would be to add more non-mesh terms to the glossary, rather than trying to remove all the non-mesh stuff. Having a glossary that defines the terms of art we use all over the project would be useful. Only having one for mesh terms is... much less useful. |
Totally agree, @kflynn. |
/hold (I want to be sure we don't accidentally merge this.) |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Moves the Glossary to the GAMMA section to avoid misunderstanding and facilitate clear understanding.
Which issue(s) this PR fixes:
#3803