-
Notifications
You must be signed in to change notification settings - Fork 571
Remove mkdocs-material-extensions #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mkdocs-material-extensions #3665
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gcs278 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The mkdocs-material-extensions package is now deprecated, and it is now integrated into mkdocs-material 9.4.
b60e543
to
f889c82
Compare
oh sorry, #3663 already took care of this |
@gcs278: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@gcs278 I actually overlooked removing this from the requirements file in my PR. This is still a valid change IMO. It never hurts to clean up unused dependencies. |
@blake Oh good point, I overlooked the requirements.txt fix I made. |
/reopen |
@gcs278: Failed to re-open PR: state cannot be changed. The remove-mkdocs-material-extensions branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Oh darn I locked myself out from this PR by force pushing it while it was closed. Created #3666 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The mkdocs-material-extensions package is now deprecated, and it's usage in mkdocs.yaml was removed in #3663. This fix also removes it from requirements.txt to prevent unnecessary installation.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: