Skip to content

Remove mkdocs-material-extensions #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Mar 7, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The mkdocs-material-extensions package is now deprecated, and it's usage in mkdocs.yaml was removed in #3663. This fix also removes it from requirements.txt to prevent unnecessary installation.

Which issue(s) this PR fixes:
N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gcs278
Once this PR has been reviewed and has the lgtm label, please assign robscott for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2025

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-test b60e543 link true /test pull-gateway-api-test
pull-gateway-api-crds-validation-5 b60e543 link true /test pull-gateway-api-crds-validation-5
pull-gateway-api-verify b60e543 link true /test pull-gateway-api-verify
pull-gateway-api-crds-validation-3 b60e543 link true /test pull-gateway-api-crds-validation-3
pull-gateway-api-crds-validation-4 b60e543 link true /test pull-gateway-api-crds-validation-4

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

The mkdocs-material-extensions package is now deprecated, and it is
now integrated into mkdocs-material 9.4.
@gcs278 gcs278 force-pushed the remove-mkdocs-material-extensions branch from b60e543 to f889c82 Compare March 7, 2025 11:27
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2025
@gcs278
Copy link
Contributor Author

gcs278 commented Mar 7, 2025

oh sorry, #3663 already took care of this
/close

@k8s-ci-robot
Copy link
Contributor

@gcs278: Closed this PR.

In response to this:

oh sorry, #3663 already took care of this
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@blake
Copy link
Contributor

blake commented Mar 7, 2025

@gcs278 I actually overlooked removing this from the requirements file in my PR. This is still a valid change IMO. It never hurts to clean up unused dependencies.

@gcs278 gcs278 changed the title Remove mkdocs-material-extensions Remove mkdocs-material-extensions from requirements.txt Mar 9, 2025
@gcs278
Copy link
Contributor Author

gcs278 commented Mar 9, 2025

@blake Oh good point, I overlooked the requirements.txt fix I made.
/open

@gcs278
Copy link
Contributor Author

gcs278 commented Mar 9, 2025

/reopen

@k8s-ci-robot
Copy link
Contributor

@gcs278: Failed to re-open PR: state cannot be changed. The remove-mkdocs-material-extensions branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Mar 9, 2025

Oh darn I locked myself out from this PR by force pushing it while it was closed.

Created #3666

@gcs278 gcs278 changed the title Remove mkdocs-material-extensions from requirements.txt Remove mkdocs-material-extensions Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants